https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42383
--- Comment #126 from Tomás Cohen Arazi (tcohen) <[email protected]> --- Created attachment 209786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209786&action=edit Bug 42383: (QA follow-up) Show the configured date format for the return date The check-in settings panel labelled the return date input 'Specify return date (MM/DD/YYYY):' whatever the dateformat system preference was. The input is a flatpickr date picker that uses the configured format, so the hint was wrong for every format but 'us'. The legacy page used date-format.inc to display the configured format. This patch (QA comment point 16) builds the hint from flatpickr_dateformat_string, set by calendar.inc from the dateformat system preference, so it reads e.g. DD/MM/YYYY, DD.MM.YYYY or YYYY-MM-DD as date-format.inc does. If it is not available, the label is displayed without a format. Test plan: 1. Enable SpecifyReturnDate and set dateformat to 'dd/mm/yyyy' 2. On the check-in page, open the check-in settings (sliders icon) => FAIL: The label reads 'Specify return date (MM/DD/YYYY):' 3. Apply this patch and rebuild: $ ktd --shell k$ yarn js:build k$ restart_all 4. Reload the page and open the settings => SUCCESS: The label reads 'Specify return date (DD/MM/YYYY):' 5. Try the other dateformat values => SUCCESS: The label matches the format used by the date picker 6. Sign off :-D Assisted-by: Opus 5.5 (Anthropic) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
