https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42383
--- Comment #136 from Tomás Cohen Arazi (tcohen) <[email protected]> --- Created attachment 209814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209814&action=edit Bug 42383: (QA follow-up) Mark the row of the resolved return claim When a return claim is resolved from the check-in page, onClaimResolved marks the first row of the table with a pending claim as resolved, not the row of the claim that was resolved. With several claimed items checked in, the wrong row loses its 'Resolve claim' button and the right one keeps it. This patch addresses point 3 of comment #77: ResolveClaimModal now passes the id of the resolved claim along with the 'resolved' event, and onClaimResolved marks the row whose return_claim message carries that claim id. A Cypress test is added: two items claimed returned are checked in, the claim of the older one (second row) is resolved, and only its row is marked as resolved. Test plan: 1. Set ClaimReturnedLostValue to any lost value, and leave AutoClaimReturnStatusOnCheckin empty 2. Check out two items to a patron, and mark both as claims returned from the patron's checkouts table 3. Check in both items on the check-in page 4. Click 'Resolve claim' on the row of the first item checked in (the second row), pick a resolution and resolve => FAIL: The first row loses its 'Resolve claim' button, the resolved item keeps it 5. Apply this patch 6. Run: $ ktd --shell k$ yarn js:build 7. Repeat 2 to 4 => SUCCESS: The row of the resolved claim is marked as resolved, the other one still offers 'Resolve claim' 8. Run: k$ yarn cypress run --spec t/cypress/integration/Circulation/Checkin_spec.ts => SUCCESS: Tests pass! 9. Sign off :-D Assisted-by: Opus 5.5 (Anthropic) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
