https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260
Martin Renvoize (ashimema) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43950 Status|Failed QA |Signed Off --- Comment #619 from Martin Renvoize (ashimema) <[email protected]> --- Thanks Andrew, all of that makes sense. Going through your points: * Confirmation patch: dropped, and its attachment is obsolete. The release notes no longer mention it. * Notice content on the print page: the notices are now printed in sandboxed frames (no scripts, forms or navigation allowed), as the notices management page and the patron's Notices tab already do for the previews, so a script in a notice cannot run in the staff session. I tried it with a script and an onerror handler in a notice: nothing runs, the browser console says the script was blocked, and the notice is printed in full. Because each notice is now in its own frame, the CSS scoping code (which had already needed several fixes) is gone, and the style of the notice template is part of the notice. The content of plain text notices is now escaped too, as it was interpreted as markup. * The IndependentBranches test: you were right, it passed whatever the preference was. It is rewritten: a patron with view_borrower_infos_from_any_libraries is restricted to their library by IndependentBranches, and does not see the notices of other libraries even when asking for them, and the ambiguous column case now forces the join so it fails without the fix. I checked both by removing the fix and by flipping the preference, and the tests fail. * CONVERTED_TO_PRINT: the Convert to print buttons are not shown when the notice does not exist, and a direct request says which notice is missing and where to create it. When the notice has an error (a missing [% END %], an unknown variable) the staff member is told it has an error, the error is logged as an error in the plack-intranet-error.log, and the notice that was to be converted is not changed. * Link between the notices: there was none, good question. The delivery note of the original now says 'Converted to print notice 123' and the one of the print notice says 'Converted from notice 122', on the notices management page and on the patron's Notices tab. * Logging: dropped from this bug, for printing as well as converting, as the Notices log does not fit. I filed bug 43950 to add a proper log module for the changes to the notices of the message queue, with the diff and the actions in sentence case, and it depends on this one. There is also a new patch with Cypress tests for the notices management page, the print page and the patron's Notices tab: the filters, what a staff member limited to their library can see and do, printing (including a script in a notice, and notices with a secret), and converting (including the two error cases). The whole series is re-attached, rebased on current main, with the sign-offs carried over, and the release notes are updated for all of this. Setting to Signed Off for another look at the new follow-ups. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43950 [Bug 43950] Add a log module for changes to the notices of the message queue -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
