https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781
Martin Renvoize (ashimema) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Extended notice |The FallbackToSMSIfNoEmail release notes|message_transport_type |system preference, which |fallback functionality |until now only applied to |implemented by |purchase suggestion |FallbackToSMSIfNoEmail |notices, now also applies |system preference to: |to these notices when the |- cronjobs (membership |patron has no email address |expiry, automatic renewal), |but has an SMS alert | |number: |- opac-shareshelf.pl |- the order received notice |(sending of SHARE_ACCEPT |(ACQ_NOTIF_ON_RECEIV), |notice when list share |- the hold cancelled on |accepted), |lost notice sent from Holds |- circ/pendingreserves.pl |to pull |(sending |(CANCEL_HOLD_ON_LOST), |'CANCEL_HOLD_ON_LOST' |- the list share accepted |notice when reserved item |notice (SHARE_ACCEPT), |marked lost in Holds to |- notices queued with |pull), |Koha::Patron->queue_notice |- C4/Acquisition.pm |for an explicitly requested |(sending |email transport (for |'ACQ_NOTIF_ON_RECEIV' |example two factor |notice to notify users of |authentication, curbside |receipt) |pickup and holds | |reminders). | | | |The SMS template of the | |notice is used. The | |fallback only happens when | |the notice has an SMS | |template: a library that | |does not want a notice sent | |by SMS does not define an | |SMS template for it, and | |the notice is sent as | |before. Notices sent | |according to the patron's | |own messaging preferences | |are not affected. Status|Failed QA |Signed Off --- Comment #34 from Martin Renvoize (ashimema) <[email protected]> --- Thanks Katrin, and sorry for the delay. Rebased onto current main (the Suggestions.pm hunk conflicted) and reworked; a QA follow-up is attached. 1) QA: Koha/Patron.pm is tidied and patrons.pref has its final newline back. koha-qa is clean apart from a pod_coverage failure for _cancel_items_receipt in C4/Acquisition.pm, which comes from bug 11744 and is untouched here. 2) Tests added: Koha::Patron->message_transport_type_for (incl. template and library cases), the queue_notice fallback, suggestion notices with and without an SMS template, and the order received notice (new t/db_dependent/Acquisition/NotifyOrderUsers.t). Checked they fail against the old Koha/Patron.pm. 3a) Opting out per notice: the fallback now only happens when the notice has an SMS template (library or default). A library that does not want a notice sent by SMS simply does not define one, and the notice is sent as before. That also answers (b): with no SMS template nothing changes, and the notice is no longer lost. Notices a patron configured through their own messaging preferences keep falling back to print and are not sent by SMS. In doing this I also found and fixed: suggestion notices falling back to SMS were still prepared with the email template; and opac-shareshelf notify_owner queued its notice without a recipient, so it could never have been sent. 3c) Pref text now reads: Enable/Disable sending notices by SMS if patron has no email address and the notice has an SMS template. The covered notices are listed in the release notes, and the expiry notice has been removed from them. I kept the wording otherwise, as the longer term plan is to replace this with a configurable fallback order (e.g. email, sms, print) in a follow-up bug that depends on this one. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
