https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44009

--- Comment #2 from David Nind <[email protected]> ---
Created attachment 210792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210792&action=edit
Bug 44009: Close the POS change-to-give modal after confirming

When FinePaymentAutoPopup is enabled, pos/pay.tt submits the payment form
to a new tab (target="_blank") so the receipt can open without a popup
blocker (Bug 41705). The POS page itself never navigates, so after
clicking "Yes" in the "amount collected is more than the outstanding
charge" modal it stays on screen.

The post-submit reset then clears the sale table, which recalculates the
change against the still-populated "Amount tendered" field and writes
that value into the modal (so "1.00" becomes the full tendered amount).
Clicking "Yes" again is blocked by the now-empty required field, and the
modal then reads 0.00. Only "No" dismisses it. The payment itself is
recorded once, on the first "Yes".

Hide the modal when "Yes" is clicked, before the form is submitted.

To test:
1. Enable EnablePointOfSale, UseCashRegisters and FinePaymentAutoPopup
   ("Do"), have a cash register and a saleable debit type.
2. In Point of Sale add an item of 1.00 and enter 2.00 as the amount
   tendered, choose Cash and a register, then Confirm.
3. Click "Yes" in the change modal.
   => Before: the modal stays open and its change figure changes.
   => After: the modal closes, the receipt opens in a new tab and the
      sale is cleared.
4. Repeat with two items and a larger tendered amount, and with an
   exact amount (no modal).
5. Confirm only one payment is recorded per sale.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Signed-off-by: David Nind <[email protected]>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to