https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44009
Bug ID: 44009
Summary: POS change-to-give modal stays open after Yes with
FinePaymentAutoPopup
Initiative type: ---
Sponsorship ---
status:
Product: Koha
Version: Main
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Point of Sale
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
Target Milestone: ---
When FinePaymentAutoPopup is enabled, pos/pay.tt submits the payment form to a
new tab (target="_blank") so the receipt can open without being blocked by the
browser (Bug 41705). The POS page itself never navigates, so after clicking
"Yes" in the "The amount collected is more than the outstanding charge" modal,
the modal stays on screen.
The post-submit reset then clears the sale table, which recalculates the change
against the still-populated "Amount tendered" field and writes that value into
the modal. For example, with a sale of 2.00 and 3.00 tendered the modal first
says the change is 1.00, and after clicking Yes it says 3.00. Clicking Yes
again is blocked by the now-empty required "Amount tendered" field and the
modal reads 0.00. Only "No" dismisses it.
The payment itself is recorded once, on the first Yes (checked in the
accountlines table), so this is a display problem, not a double charge. It is
much more confusing at a till, and sites that make the modal static (no
backdrop or Escape dismissal) cannot dismiss it except with No.
The patch hides the modal when Yes is clicked, before the form is submitted.
Reproduced on 25.11.x. The relevant code is identical on main (the same
setTimeout reset in the FinePaymentAutoPopup branch and no modal hide), but I
have only reproduced it on 25.11.
Test plan:
1. Enable EnablePointOfSale, UseCashRegisters and FinePaymentAutoPopup ("Do").
Have a cash register and a debit type that can be sold.
2. In Point of sale add an item of 1.00 and enter 2.00 as the amount tendered.
Choose Cash and a register, then click Confirm.
3. Click "Yes" in the change modal.
=> Before the patch: the modal stays open and its change figure changes.
After: the modal closes, the receipt opens in a new tab and the sale is
cleared.
4. Repeat with two items and a larger tendered amount, and with an exact amount
(no modal appears).
5. Confirm only one payment is recorded per sale.
6. Set FinePaymentAutoPopup to "Don't show" and repeat step 2: the modal closes
on Yes and the "Payment received" page is shown, as before.
Sponsored-by: OpenFifth <https://openfifth.co.uk/>
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
