http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861
M. de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #9 from M. de Rooy <[email protected]> --- Just some preliminary QA comments while signing off (for the QAer on duty): Cardnumber already in use or not in a good format: I would personally like to differentiate between the two messages. Is it in use? Or is just the length incorrect? The min and maxlength logic in memberentry.pl should be in a module? Isn't there a way to check field length earlier with javascript than waiting for Save? I am not a fan of my $qr = qr|^\d{$length}$|; and just pasting the pref inside the regex. You just assume that it is of the form m,n but you do not really know. Why not just pull them out of the pref with a regex like (\d+),(\d+) or similar? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
