http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861
--- Comment #10 from Jonathan Druart <[email protected]> --- (In reply to M. de Rooy from comment #9) > Just some preliminary QA comments while signing off (for the QAer on duty): Thanks Marcel, yours remarks allowed me to improve the code. > Cardnumber already in use or not in a good format: I would personally like > to differentiate between the two messages. Is it in use? Or is just the > length incorrect? Will be fixed > The min and maxlength logic in memberentry.pl should be in a module? New routine and UT will be provided. > Isn't there a way to check field length earlier with javascript than waiting > for Save? It is already done. I use the pattern attribute on the input html tag. > I am not a fan of my $qr = qr|^\d{$length}$|; and just pasting the pref > inside the regex. > You just assume that it is of the form m,n but you do not really know. > Why not just pull them out of the pref with a regex like (\d+),(\d+) or > similar? I use the code which was in the pl file from the pm. It avoids that. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
