* Mason James ([email protected]) wrote: > > On 2012-01-21, at 3:48 AM, Galen Charlton wrote: > > > Hi, > > > > On Jan 20, 2012, at 2:59 AM, Mason James wrote: > >> i think i'm gonna send a patch to add the S::C module as a Koha > >> dependency, a good idea? > > > > As an optional dependency, maybe. But there's nothing stopping anybody > > from using it for their debugging now, right? > > > > Smart::Comments is a source filter -- and consequently may cause a modest > > but measurable performance hit if it were enabled across the board -- and > > some cursory Googling suggests that it may not have played well with > > mod_perl in the past. I don't know, and haven't yet tested, whether that's > > still the case, but I do think that should be checked before such a patch > > is accepted. > > > > Thinking aloud, perhaps (for Debian and friends) maybe it belongs as a > > dependency brought in by a new koha-dev-tools package? > > > > Regards, > > > > Galen > > > cool, thanks for the replies everyone :) > > so, lets use both Smart::Comments and Data::Dumper > > > hmmm, shall we start wrapping the loading of Koha debug modules in a 'if > ($DEBUG) {use Smart::Comments}' type code block - as a performance tweak? > > > would that work?
No because the use is called anyway, you can conditionally use a use call. You would need to do require and import. Chris > _______________________________________________ > Koha-devel mailing list > [email protected] > http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : http://www.koha-community.org/ > git : http://git.koha-community.org/ > bugs : http://bugs.koha-community.org/ -- Chris Cormack Catalyst IT Ltd. +64 4 803 2238 PO Box 11-053, Manners St, Wellington 6142, New Zealand
signature.asc
Description: Digital signature
_______________________________________________ Koha-devel mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
