On Mon, Apr 9, 2012 at 8:08 PM, Chris Cormack <[email protected]>
wrote:
>
> 2012/4/10 Chris Nighswonger <[email protected]>:
> > On Mon, Apr 9, 2012 at 1:03 PM, Dobrica Pavlinusic <[email protected]>
> > wrote:
> >>
> >>
> >> > - Simplifying code
> >> > - Minimizing XML parsing
> >>
> >> I had one patch with this which uses marc instead of marcxml from
> >> biblioitems to provide huge performance improvement:
> >>
> >>
> >>
http://git.rot13.org/?p=koha.git;a=commitdiff;h=a18a7f709447cccf617e8fa5b545d6a82606deeb;hp=095b0af09d6cbc2bf579ba6ae353b9715b035118
> >>
> >> (it needs cleanup, rebase and probably own bug)
> >>
> >
> > That's spectacular. What's keeping us from pushing that now?
> >
> It is indeed spectacular
>
> Unfortunately, it is now missing all the item information. So it still
> needs to call C4::Biblio::EmbedItemsInMarcBiblio($record,
> $biblionumber) if ($embeditems);
>
> Can you test it with that ?
>
One other thought:
Won't $record = MARC::Record::new_from_usmarc( $row->{marc} ) choke on
normarc, unimarc, and friends?
I'm wondering if this was not part of the reason we went to XML...
Kind Regards,
Chris
_______________________________________________
Koha-devel mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
