Hi! Looks good to me in the principle.
But are you sure there is a space at the end of the following string? + s/^Subroutine .* redefined $// for @errors; I still don't see the point in using Smart::Comments. For me it is just debug messages and it is not intended to be in the master branch. Perhaps could we use a log module if we want these kind of information to be displayed? For discussion, Jonathan 2012/11/1 Mason James <[email protected]> > > On 2012-10-25, at 3:56 PM, Mason James wrote: > > > > > heya Jonathan > > > > thanks for this, ill do some testing then push your changes up to the > kc.org github repo > > > > fyi: I've done this, and changed the repo name as promised > > its now 'koha-qa-test', not 'koha-qa-tool' > -> https://github.com/Koha-Community/koha-qa-test > > > I've also added a patch to ignore the many 'Subroutine $FOO redefined' > warnings in Koha, that have been causing some false-postive QA fails > i think this is the best thing to do, until we fix these warnings... > > > https://github.com/Koha-Community/koha-qa-test/commit/17175212b3b06fac63f88118e26b3e3fff6806e6 > > > bug 8559 is a good example of a patch ?incorrectly? failing, due to this > warning type > -> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 > > > are people ok with this patch?, or is there a better way? > > _______________________________________________ > Koha-devel mailing list > [email protected] > http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : http://www.koha-community.org/ > git : http://git.koha-community.org/ > bugs : http://bugs.koha-community.org/ >
_______________________________________________ Koha-devel mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
