On 2012-11-2, at 10:34 PM, Jonathan Druart wrote: > Hi! > > Looks good to me in the principle. > > But are you sure there is a space at the end of the following string? > + s/^Subroutine .* redefined $// for @errors;
yes, there is a trailing space > > I still don't see the point in using Smart::Comments. For me it is just debug > messages and it is not intended to be in the master branch. currently, any debug messages can be deleted, none are important > Perhaps could we use a log module if we want these kind of information to be > displayed? ok great, please use a log module to display/log any info you want but, please leave the 'use Smart::Comments' statements, i need these to continue to debug using S::C _______________________________________________ Koha-devel mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
