(moving this discussion to koha-devel) Koha currently just uses regular expressions to match against IP addresses (see line 1040 or so in latest C4/Auth.pm). While this isn't terribly elegant, it's at least simple; what additional benefits does Net::IP::Match::XS bring? (It would also be a problematic dependency, given that it's not currently a Debian package.)
2015-06-24 22:59 GMT-06:00 Nicholas van Rheede van Oudtshoorn < [email protected]>: > Greetings everyone, > > As I'm still very much a perl newbie, I'd love to get some feedback on a > patch I just pushed to bug 14407 (my own bug!) We use Self-Checkout here > <http://library.pbc.wa.edu.au/>, with users just having to scan their > barcode to take books out. Our OPAC is also live over the internet. That > means that anyone who knows Koha, can access the self-checkout from off > campus! This patch adds a preference allowing one to limit access to those > pages to specific IP addresses or ranges. I've used Net::IP::Match::XS to > do the heavy lifting - is there another library that Koha already uses to > do the same sort of thing? > > Thanks in advance, > Nick > Perth Bible College <http://www.pbc.wa.edu.au/> > > > _______________________________________________ > Koha-patches mailing list > [email protected] > http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-patches > website : http://www.koha-community.org/ > git : http://git.koha-community.org/ > bugs : http://bugs.koha-community.org/ > -- Jesse Weaver
_______________________________________________ Koha-devel mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
