Hi Joonas, I've left a comment. After re-reading the code, I think I can see your perspective.
I don't love the patches, but I'm not going to stand in their way either. I can always just leave the system preference turned off. David Cook Software Engineer Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Online: 02 8005 0595 -----Original Message----- From: Joonas Kylmälä <joonas.kylm...@helsinki.fi> Sent: Tuesday, 8 September 2020 5:20 PM To: dc...@prosentient.com.au Cc: 'koha-devel' <koha-devel@lists.koha-community.org> Subject: Re: [Koha-devel] Request for sign-off: component part records feature (Bug 11175) Hi, On 08/09/2020 10:15, dc...@prosentient.com.au wrote: > I've just taken a look at comment 59 but I'm not sure why you decided to > rescue it based on that comment. I did it so that the GUI code does not need to be rewritten because it takes time. > I'm happy to leave some feedback on the bug report. I'll do that quickly now. Thanks! -- Joonas Kylmälä Tietojärjestelmäasiantuntija Kansalliskirjasto Kirjastoverkkopalvelut PL 15 (Unioninkatu 36) 00014 Helsingin yliopisto _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
