Hi, On Fri, Mar 6, 2009 at 5:37 AM, <[email protected]> wrote: > From: Nahuel Angelinetti <[email protected]> > > Signed-off-by: Henri-Damien LAURENT <[email protected]>
The concerns I raised when I reject this patch in October still have not been addressed. From my email of 10/23/2008: "1. The patch description needs improvement - it doesn't identify which syspref it's talking about, it doesn't make it clear that it's talking about the ISBD display, and there really ought to be an example of what the patch is trying to accomplish. 2. This patch changes opac-ISBDdetail.pl, but doesn't change catalogue/ISBDdetail.pl, even though the ISBD display logic is virtually identical. 3. In fact, the logic that generates the ISBD display really ought to be factored into a common routine that's referred to by both the staff and OPAC scripts." Regards, Galen -- Galen Charlton VP, Research & Development, LibLime [email protected] p: 1-888-564-2457 x709 skype: gmcharlt _______________________________________________ Koha-patches mailing list [email protected] http://lists.koha.org/mailman/listinfo/koha-patches
