Hi, Le Fri, 6 Mar 2009 12:41:39 -0500, Galen Charlton <[email protected]> a écrit :
> Hi, > > On Fri, Mar 6, 2009 at 5:37 AM, <[email protected]> > wrote: > > From: Nahuel Angelinetti <[email protected]> > > > > Signed-off-by: Henri-Damien LAURENT > > <[email protected]> > > The concerns I raised when I reject this patch in October still have > not been addressed. From my email of 10/23/2008: > > "1. The patch description needs improvement - it doesn't identify > which syspref it's talking about, it doesn't make it clear that it's > talking about the ISBD display, and there really ought to be an > example of what the patch is trying to accomplish. > > 2. This patch changes opac-ISBDdetail.pl, but doesn't change > catalogue/ISBDdetail.pl, even though the ISBD display logic is > virtually identical. > > 3. In fact, the logic that generates the ISBD display really ought to > be factored into a common routine that's referred to by both the staff > and OPAC scripts." I just resent 2 patchs that extract the ISBD view generation to a C4::Biblio function. And which implements the needed functionnality. bests, -- Nahuel ANGELINETTI _______________________________________________ Koha-patches mailing list [email protected] http://lists.koha.org/mailman/listinfo/koha-patches
