So, for the LostAndReturned scenario we've now got two bugs detailing the issue and Nick C has managed to build a test case which I've used to work out a solution.
Please take a look at bug 22877 and bug 20769 and let us know if you feel these cover all the cases in this thread. Many thanks, Martin On Mon, 29 Apr 2019, 7:04 pm Arturo Longoria, <[email protected]> wrote: > I thought I'd provide an update on this. We had a patron return 5 items > today that had entered Long Overdue (Lost) status via our long overdue cron > job. These had already accrued their max fines. > > We wanted to test the behavior of CalculateFinesOnReturn, which we had set > to "Do". Upon checking in the first item, yes, the fines were doubled up on > a new line item -- *not* the behavior we want. > > I switched CalculateFinesOnReturn to "Don't", checked in another item, and > this time there was no doubled-up fine -- the behavior we *do* want! > > I toggled a couple more times and the behavior was the same. > > We have switched CalculateFinesOnReturn to "Don't" and will continue > monitoring to see if there are any unexpected changes. > > > Arturo Longoria > Reference Librarian/Web Manager > Texas State Law Library > www.sll.texas.gov > > -----Original Message----- > From: Arturo Longoria > Sent: Wednesday, April 17, 2019 15:37 > To: Margo Duncan <[email protected]>; Renvoize, Martin < > [email protected]>; Koha <[email protected]> > Subject: RE: [Koha] double fines > > Our library is still on 18.05.10, so I'm not sure it's specific to 18.11, > unfortunately. > > A new related bug has been filed here, > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22727, but that > doesn't seem to capture what's happening at our library because our > WhenLostForgiveFine preference is set to "Don't Forgive," not "Forgive" as > the bug description indicates. > > Arturo Longoria > Reference Librarian/Web Manager > Texas State Law Library > www.sll.texas.gov > > -----Original Message----- > From: Margo Duncan <[email protected]> > Sent: Wednesday, April 17, 2019 15:31 > To: Arturo Longoria <[email protected]>; Renvoize, Martin < > [email protected]>; Koha <[email protected]> > Subject: RE: [Koha] double fines > > We run fines.pl hourly (it takes between 11 and 15 minutes to run) as > well as CalculateFinesOnReturn set to Do and it's been set that way for a > long time. > > We only started seeing the double fines since we upgraded to 18.11 (from > 18.05) in February. > > Margo > > > -----Original Message----- > From: Koha [mailto:[email protected]] On Behalf Of Arturo > Longoria > Sent: Wednesday, April 17, 2019 8:53 AM > To: Renvoize, Martin <[email protected]>; Koha < > [email protected]> > Subject: Re: [Koha] double fines > > Our fines.pl job runs daily, but we don't have much circulation, so while > I don't have the numbers on hand (since our Koha is managed by ByWater > Solutions), I can't imagine it runs longer than a few minutes. > > If this happens again or if I can detect some kind of pattern, I can > provide an update to this thread. > > Arturo Longoria > Reference Librarian/Web Manager > Texas State Law Library > > https://urldefense.proofpoint.com/v2/url?u=http-3A__www.sll.texas.gov&d=DwIGaQ&c=e7TYJBzRfB0YbjEn2u3vBA&r=roY6qGYXhOv2NYP41kw392iquieY_agvyS3IdaEsCh0&m=7o-Qc-3YVcQHDSj78lAn8vvGqiaU17d5f_1wJWEC-Ls&s=louv4K8SfwGLaj3pogvOx3hSuzKErS0bWXLTSI5z9P4&e= > > -----Original Message----- > From: Koha <[email protected]> On Behalf Of Renvoize, Martin > Sent: Tuesday, April 16, 2019 02:42 > To: Koha <[email protected]> > Subject: Re: [Koha] double fines > > For those experiencing this issue, how often are you running fines.pl and > what sort of overdues numbers are we talking about, does the job take > minutes or hours to run to completion? It feels like we may have a race > condition somewhere here. > > We do have a number of customers here with the fines job running nightly > and the finesMode set to `Calculate and charge` along with > CalculateFinesOnReturn set to `Do` and none have reported this issue to > date that I'm aware of. > > *Martin Renvoize* > > < > https://urldefense.proofpoint.com/v2/url?u=https-3A__www.ptfs-2Deurope.com&d=DwIGaQ&c=e7TYJBzRfB0YbjEn2u3vBA&r=roY6qGYXhOv2NYP41kw392iquieY_agvyS3IdaEsCh0&m=7o-Qc-3YVcQHDSj78lAn8vvGqiaU17d5f_1wJWEC-Ls&s=B-QOK2TcJ15pGvQTkg3rjYVoyGdY2Op9wr5MExuvbT4&e= > > > > Development Team Manager > > > > > > *Phone:* +44 (0) 1483 378728 > > *Mobile:* +44 (0) 7725 985 636 > > *Email:* [email protected] > > *Fax:* +44 (0) 800 756 6384 > > > > https://urldefense.proofpoint.com/v2/url?u=http-3A__www.ptfs-2Deurope.com&d=DwIGaQ&c=e7TYJBzRfB0YbjEn2u3vBA&r=roY6qGYXhOv2NYP41kw392iquieY_agvyS3IdaEsCh0&m=7o-Qc-3YVcQHDSj78lAn8vvGqiaU17d5f_1wJWEC-Ls&s=9zCwfMNwX8SN3zK6Qk6uEJ1RczjjB5SIX0tWa7z4V_4&e= > > > > > > > > Registered in the United Kingdom No. 06416372 VAT Reg No. 925 7211 30 > > The information contained in this email message may be privileged, > confidential and protected from disclosure. If you are not the intended > recipient, any dissemination, distribution or copying is strictly > prohibited. If you think that you have received this email message in > error, please email the sender at [email protected] > > > > On Mon, 15 Apr 2019 at 22:44, Caroline Cyr-La-Rose < > [email protected]> wrote: > > > I've noticed this in the past too. I always tell administrators to > > choose EITHER > > > > * finesMode set to "Calculate and charge", with fines.pl set to run > > nightly, OR > > * CalculateFinesOnReturn set to "Do" > > > > Both turned on always gave me trouble. I thought it was meant to be a > > choice between calculating fines nightly with the cron or calculate on > > return. > > > > Caroline > > > > > > On 19-04-14 22 h 02, vikram zadgaonkar wrote: > > > Hi, > > > I am also facing same problem. I have enabled calculate fine on return. > > > > > > > > > On Mon 15 Apr, 2019, 12:10 AM Katrin Fischer, > > > <[email protected]> > > > wrote: > > > > > >> Hi Margo, > > >> > > >> I am not aware of any known bugs that fit your description. :( > > >> > > >> Maybe it could help to see the 2 lines in accountlines (F and FU) > > >> and compare these. > > >> > > >> Do you have |CalculateFinesOnReturn enabled?| > > >> > > >> |Katrin > > >> | > > >> > > >> > > >> On 10.04.19 20:01, Margo Duncan wrote: > > >>> Good afternoon, > > >>> > > >>> Recently we have some patrons that are being double charged fines. > > >>> It > > >> looks like when the item is turned in, the accruing fine (FU) > > >> remains > > and a > > >> fine (F) for the same amount is added as a second line. It doesn't > > appear > > >> to be happening to all patrons and I cannot determine a pattern. > > >>> We are on version 18.11.02. > > >>> > > >>> Has anyone had this problem? Or any suggestions where to start > > looking? > > >>> Thank you! > > >>> Margo > > >>> > > >>> Margo Duncan, MLS > > >>> Head of Library Systems > > >>> Robert R. Muntz Library > > >>> The University of Texas at Tyler > > >>> 903.566.7174 | [email protected]<mailto:[email protected]> > > >>> > > >>> _______________________________________________ > > >>> Koha mailing list > > >>> https://urldefense.proofpoint.com/v2/url?u=http-3A__koha-2Dcommuni > > >>> ty.org&d=DwIGaQ&c=e7TYJBzRfB0YbjEn2u3vBA&r=roY6qGYXhOv2NYP41kw392i > > >>> quieY_agvyS3IdaEsCh0&m=7o-Qc-3YVcQHDSj78lAn8vvGqiaU17d5f_1wJWEC-Ls > > >>> &s=V92qn7BzwFebUJGvqAof05C3ywrJs2rsdyWdw5GL1o4&e= > > >>> [email protected] > > >>> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.katipo. > > >>> co.nz_mailman_listinfo_koha&d=DwIGaQ&c=e7TYJBzRfB0YbjEn2u3vBA&r=ro > > >>> Y6qGYXhOv2NYP41kw392iquieY_agvyS3IdaEsCh0&m=7o-Qc-3YVcQHDSj78lAn8v > > >>> vGqiaU17d5f_1wJWEC-Ls&s=63FvNWb9WfT7yB3fvYoM5M-PLib9Irj2mCejDwF2sC > > >>> M&e= > > >> _______________________________________________ > > >> Koha mailing list > > >> https://urldefense.proofpoint.com/v2/url?u=http-3A__koha-2Dcommunit > > >> y.org&d=DwIGaQ&c=e7TYJBzRfB0YbjEn2u3vBA&r=roY6qGYXhOv2NYP41kw392iqu > > >> ieY_agvyS3IdaEsCh0&m=7o-Qc-3YVcQHDSj78lAn8vvGqiaU17d5f_1wJWEC-Ls&s= > > >> V92qn7BzwFebUJGvqAof05C3ywrJs2rsdyWdw5GL1o4&e= > > >> [email protected] > > >> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.katipo.c > > >> o.nz_mailman_listinfo_koha&d=DwIGaQ&c=e7TYJBzRfB0YbjEn2u3vBA&r=roY6 > > >> qGYXhOv2NYP41kw392iquieY_agvyS3IdaEsCh0&m=7o-Qc-3YVcQHDSj78lAn8vvGq > > >> iaU17d5f_1wJWEC-Ls&s=63FvNWb9WfT7yB3fvYoM5M-PLib9Irj2mCejDwF2sCM&e= > > >> > > > _______________________________________________ > > > Koha mailing list > > > https://urldefense.proofpoint.com/v2/url?u=http-3A__koha-2Dcommunity > > > .org&d=DwIGaQ&c=e7TYJBzRfB0YbjEn2u3vBA&r=roY6qGYXhOv2NYP41kw392iquie > > > Y_agvyS3IdaEsCh0&m=7o-Qc-3YVcQHDSj78lAn8vvGqiaU17d5f_1wJWEC-Ls&s=V92 > > > qn7BzwFebUJGvqAof05C3ywrJs2rsdyWdw5GL1o4&e= [email protected] > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.katipo.co > > > .nz_mailman_listinfo_koha&d=DwIGaQ&c=e7TYJBzRfB0YbjEn2u3vBA&r=roY6qG > > > YXhOv2NYP41kw392iquieY_agvyS3IdaEsCh0&m=7o-Qc-3YVcQHDSj78lAn8vvGqiaU > > > 17d5f_1wJWEC-Ls&s=63FvNWb9WfT7yB3fvYoM5M-PLib9Irj2mCejDwF2sCM&e= > > > -- > > > Caroline Cyr La Rose, M.L.I.S. > > > Librarian | Product Manager > > > > > > Phone: 1-833-465-4276, ext. 221 > > > [email protected] > > > <mailto:[email protected]> > > > > > > INLiBRO | Document Technologies Specialists | > > > https://urldefense.proofpoint.com/v2/url?u=http-3A__www.inLibro.com&; > > > d=DwIGaQ&c=e7TYJBzRfB0YbjEn2u3vBA&r=roY6qGYXhOv2NYP41kw392iquieY_agv > > > yS3IdaEsCh0&m=7o-Qc-3YVcQHDSj78lAn8vvGqiaU17d5f_1wJWEC-Ls&s=Mc46Z_E_ > > > 52n0_Ruydh-DkD-dmitR31rcq1jUrSfEY74&e= > > > <https://urldefense.proofpoint.com/v2/url?u=http-3A__www.inLibro.com > > > &d=DwIGaQ&c=e7TYJBzRfB0YbjEn2u3vBA&r=roY6qGYXhOv2NYP41kw392iquieY_ag > > > vyS3IdaEsCh0&m=7o-Qc-3YVcQHDSj78lAn8vvGqiaU17d5f_1wJWEC-Ls&s=Mc46Z_E > > > _52n0_Ruydh-DkD-dmitR31rcq1jUrSfEY74&e=> > > _______________________________________________ > > Koha mailing list > > https://urldefense.proofpoint.com/v2/url?u=http-3A__koha-2Dcommunity.o > > rg&d=DwIGaQ&c=e7TYJBzRfB0YbjEn2u3vBA&r=roY6qGYXhOv2NYP41kw392iquieY_ag > > vyS3IdaEsCh0&m=7o-Qc-3YVcQHDSj78lAn8vvGqiaU17d5f_1wJWEC-Ls&s=V92qn7Bzw > > FebUJGvqAof05C3ywrJs2rsdyWdw5GL1o4&e= [email protected] > > https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.katipo.co.n > > z_mailman_listinfo_koha&d=DwIGaQ&c=e7TYJBzRfB0YbjEn2u3vBA&r=roY6qGYXhO > > v2NYP41kw392iquieY_agvyS3IdaEsCh0&m=7o-Qc-3YVcQHDSj78lAn8vvGqiaU17d5f_ > > 1wJWEC-Ls&s=63FvNWb9WfT7yB3fvYoM5M-PLib9Irj2mCejDwF2sCM&e= > > > _______________________________________________ > Koha mailing list > https://urldefense.proofpoint.com/v2/url?u=http-3A__koha-2Dcommunity.org&d=DwIGaQ&c=e7TYJBzRfB0YbjEn2u3vBA&r=roY6qGYXhOv2NYP41kw392iquieY_agvyS3IdaEsCh0&m=7o-Qc-3YVcQHDSj78lAn8vvGqiaU17d5f_1wJWEC-Ls&s=V92qn7BzwFebUJGvqAof05C3ywrJs2rsdyWdw5GL1o4&e= > [email protected] > https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.katipo.co.nz_mailman_listinfo_koha&d=DwIGaQ&c=e7TYJBzRfB0YbjEn2u3vBA&r=roY6qGYXhOv2NYP41kw392iquieY_agvyS3IdaEsCh0&m=7o-Qc-3YVcQHDSj78lAn8vvGqiaU17d5f_1wJWEC-Ls&s=63FvNWb9WfT7yB3fvYoM5M-PLib9Irj2mCejDwF2sCM&e= > _______________________________________________ > Koha mailing list > https://urldefense.proofpoint.com/v2/url?u=http-3A__koha-2Dcommunity.org&d=DwIGaQ&c=e7TYJBzRfB0YbjEn2u3vBA&r=roY6qGYXhOv2NYP41kw392iquieY_agvyS3IdaEsCh0&m=7o-Qc-3YVcQHDSj78lAn8vvGqiaU17d5f_1wJWEC-Ls&s=V92qn7BzwFebUJGvqAof05C3ywrJs2rsdyWdw5GL1o4&e= > [email protected] > > https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.katipo.co.nz_mailman_listinfo_koha&d=DwIGaQ&c=e7TYJBzRfB0YbjEn2u3vBA&r=roY6qGYXhOv2NYP41kw392iquieY_agvyS3IdaEsCh0&m=7o-Qc-3YVcQHDSj78lAn8vvGqiaU17d5f_1wJWEC-Ls&s=63FvNWb9WfT7yB3fvYoM5M-PLib9Irj2mCejDwF2sCM&e= > _______________________________________________ Koha mailing list http://koha-community.org [email protected] https://lists.katipo.co.nz/mailman/listinfo/koha
