On Sat, 05 Aug 2006 01:02:31 +0200, Olivier Goffart <[EMAIL PROTECTED]> wrote:
> Le samedi 5 août 2006 00:20, Roman Jarosz a écrit : >> Here's the patch to enable storage backend. >> >> Can I commit? > > About this patch: > > * You forgot to remove the code which is now unused (loadXML/saveXML) :-) I didn't want to remove it just yet. > * retry every minutes if it fail ? Why ? Why? I don't know, it was done this way in old code so I leaved it in new too. > > > > > About the storage system in general: > > 0) I personally believe we don't need 100 storage system. Only one is enough > (the akonady one). But abstraction can't hurt, and it's already coded, so > foget it. we need xml for compatibility with old Kopete version so at least two storages :) > > 1) Operation should be done assyncronous > > 2) why isValid() ? save() and load() should just return a bolean When it will be done assyncronous than I think we need isValid() otherwise we don't. > > 3) since save() use info from Kopete::ContactList, i think that load could > also add directly contacts and group into it. Not hard to do, we only have to agree on that. > > 4) the contactlist backends should probably not be in libkopete Maybe. > > This is just few thought, i know this is an early state of development. > Thanks to all that are still coding for Kopete > Roman _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
