Hiya,

In my patch to speed up formatStyleKeywords I already mentioned that there is 
one much bigger fish: the call to message.plainBody().

It is used *ONLY* to determine whether a message is LTR or RTL for bidi 
locales. That is a lot of overkill.

My first feeling is to use the rich text body for QString::isRightToLeft(), 
but I don't know if the markup causes wrong results. Thiago, do you know?

The alternative is to add an isRightToLeft() to Kopete::Message that caches 
the result.

Any other options?

Any comments?

(btw, commenting out the call and hardcoding LTR gives over 50% speed 
improvement for the entire method, so this baby is worth the optimization big 
time)

-- 
Martijn

Philosopher: One who always knows what to do until it happens to him.
_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to