On Thursday 14 June 2007 13:34:30 Olivier Goffart wrote: > Le jeudi 14 juin 2007, Gustavo Pichorim Boiko a écrit : > > On Thursday 14 June 2007 12:42:41 Olivier Goffart wrote: > > > Le jeudi 14 juin 2007, Gustavo Pichorim Boiko a écrit : > > > > Ok, so I'm creating a branch work/kopete/identity_refactory to start > > > > working on this. The plan is: > > > > > > [...] > > > > > > This is basically exactly my vision of identities. > > > > > > I would also add an implementation detail that there would be one self > > > metacontact per identities (ContactList::self() would be split) > > > > I was thinking about something simpler than adding a metacontact: > > creating a IdentityContact (which would be derived from Kopete::Contact), > > and use one contact per identity. This would simplify some things IMO, > > because you wouldn't need the property source stuff (like nickname > > source, photo source and so on): properties always come from the > > IdentityContact. > > I don't understand. > The identity contact would be only for the self contact ? I think that > would be a big change, since lot of code (specially in the chat session) is > based on the fact that myself() is a normal contact. Also all protocols > have to be changed.
IMO chatwindow will still use the myself() contact from the account, no? I thought about that, and we would need to still keep the myself() contacts for the protocols, they would still be needed. The identity contact would be used to set online status for the identity accounts, and to set/get user info (either from the akonadi side, or from the server side, or from the info dialog. What would be the advantage of using metacontact? > Or else if every contact are identitycontact i don't see the interest. > nickname source and photo source are specially for contact that are _not_ > the myself contact. (it's also used for the myself contact) It is used in the metacontact (that's why I think metacontact is not a good idea for the identity. > theses source are in order to know from which contact comes the nick and > the avatar if you have several contacts into a contact in your contactlist, > this is not related to identity (althought the global identity code also > use that, but that's unrelated) That is what I propose: we do not use different photo/nickname for accounts on the same identity: they are all synchronized and use the same info (the info does not come from the account, but from the identity contact) Cheers -- Gustavo Pichorim Boiko ----------------------------------- KDE Developer www.kde.org Mandriva Labs www.mandriva.com _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
