On Jun 14, 2007, at 11:34 AM, Olivier Goffart wrote: > Le jeudi 14 juin 2007, Gustavo Pichorim Boiko a écrit : >> On Thursday 14 June 2007 12:42:41 Olivier Goffart wrote: >>> Le jeudi 14 juin 2007, Gustavo Pichorim Boiko a écrit : >>>> Ok, so I'm creating a branch work/kopete/identity_refactory to >>>> start >>>> working on this. The plan is: >>> >>> [...] >>> >>> This is basically exactly my vision of identities. >>> >>> I would also add an implementation detail that there would be one >>> self >>> metacontact per identities (ContactList::self() would be split) >> >> I was thinking about something simpler than adding a metacontact: >> creating >> a IdentityContact (which would be derived from Kopete::Contact), >> and use >> one contact per identity. This would simplify some things IMO, >> because you >> wouldn't need the property source stuff (like nickname source, >> photo source >> and so on): properties always come from the IdentityContact. > > I don't understand. > The identity contact would be only for the self contact ? I think > that would > be a big change, since lot of code (specially in the chat session) > is based > on the fact that myself() is a normal contact. Also all protocols > have to be > changed. >
which we need to remove. The myself() contact should be special in some way. Having it otherwise causes too many other problems and will let us fix some bugs along the way (can't add yourself to your contactlist, for example, which is apparently pretty important for everybody else) > Or else if every contact are identitycontact i don't see the interest. > > nickname source and photo source are specially for contact that are > _not_ the > myself contact. (it's also used for the myself contact) > theses source are in order to know from which contact comes the > nick and the > avatar if you have several contacts into a contact in your > contactlist, this > is not related to identity (althought the global identity code > also use > that, but that's unrelated) > > Or i misunderstood. > It is related to identity. From where I'm sitting, this is just a massive refactoring of the global identity stuff. -- Matt _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
