2007/8/3, Dmitry Suzdalev <[EMAIL PROTECTED]>: > > hi, guys! > > In previous thread I came to the conclusion that the best way to > proceed with that nasty no-default-style-gets picked bug is to start > using style names rather then style paths, i.e. convert names to paths > in only several places where it is actually needed. These seems to > simplify code a bit and fix bug :) > > So here's the patch that makes kopete use style names instead of style > Paths. > I hope I not forgot anything. > It works for me here in all cases (upon first run of ChatMessagePart > and during selection of styles in config dialog). > One QHash (key=styleName, value=Path) got removed, because now only > names are stored - in a simple QStringLists > > Well, check it out and tell me what do you think. > There are still some thing to do - fix apidocs (which still refer to > stylePaths) and remove usage of "slash-hack" in two functions in > KopeteStyleManager. I'll do that later, if you agree with current > proposal :). > > I tried hard not to mess up your tab based indentation (sorry, but > it's weird! while kdelibs and most other modules use spaces, kopete > uses tabs - very unpleasant for newcomer :-P) > > /me is sitting and waiting for a feedback > > Dmitry. > > _______________________________________________ > kopete-devel mailing list > [email protected] > https://mail.kde.org/mailman/listinfo/kopete-devel
I now recall why I used path instead of name. It was to avoid conflict between the same style installed in differents place ex: global /usr/share and $KDEHOME/.share/apps/kopete/styles. I found style to be better error prone than name. Now, thinking about it, this case rarely happens. I think KStandardDirs first look into $KDEHOME. If not, then ChatWindowStyleManager should priorise styles installed in the home directory. But, the patch looks fine to me
_______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
