-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Aug 3, 2007, at 8:47 AM, Dmitry Suzdalev wrote: > hi, guys! > > In previous thread I came to the conclusion that the best way to > proceed with that nasty no-default-style-gets picked bug is to start > using style names rather then style paths, i.e. convert names to paths > in only several places where it is actually needed. These seems to > simplify code a bit and fix bug :) > > So here's the patch that makes kopete use style names instead of > style Paths. > I hope I not forgot anything. > It works for me here in all cases (upon first run of ChatMessagePart > and during selection of styles in config dialog). > One QHash (key=styleName, value=Path) got removed, because now only > names are stored - in a simple QStringLists > > Well, check it out and tell me what do you think. > There are still some thing to do - fix apidocs (which still refer to > stylePaths) and remove usage of "slash-hack" in two functions in > KopeteStyleManager. I'll do that later, if you agree with current > proposal :). > > I tried hard not to mess up your tab based indentation (sorry, but > it's weird! while kdelibs and most other modules use spaces, kopete > uses tabs - very unpleasant for newcomer :-P) > > /me is sitting and waiting for a feedback > > Dmitry. > <kopete-style-path-to-name.diff> Nice patch. Thank you for making the effort to keep the coding style consistent. It is very much appreciated, even if it is weird. :) Please commit. - -- Matt -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (Darwin) iD8DBQFGs4ToA6Vv5rghv0cRAlNlAJ43+nFqy0jORUOw3obrbLCN9qi+GQCfaSZ0 lts0jgSMpo9X2qUaynzZ6Bg= =h9XR -----END PGP SIGNATURE----- _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
