Le vendredi 15 août 2008, Roman Jarosz a écrit :
> Hi
>
> I've removed the ugly dialog which is shown when we got file transfer
> request and moved it into the chat window.
>
> It's based on Adium chat style (FileTransferRequest.html) although to make
> it more user friendly I had to add four new keywords %fileSize%,
> %saveFileHandlerId%, %saveFileAsHandlerId%, %cancelRequestHandlerId%.
> The three id keywords are used to disable buttons after file transfer
> is accepted or rejected.
>
> If current style doesn't have FileTransferRequest.html Kopete creates
> default one based on current chat style.
>
> Here are screenshots:
> http://kedge.wz.cz/kopete/kopeteft1.png
> http://kedge.wz.cz/kopete/kopeteft2.png
> http://kedge.wz.cz/kopete/kopeteft3.png

Cool, great works

Comments:

- PLEASE DO NOT ENABLE JAVASCRIPT BY DEFAULT!  No security whole in kopete 
please :-)      enable it on demand just when we need it.  but javascript 
injection stuff should not be possible.

- there is a new fileTransferId  in Kopete::Message.  Could it become a 
message id.  It could be used for some others stuff (i'm thinking about 
aknoweldgement of messages)

- internaly maybe the whole filtertansfer suff should go in a different 
structure in the d ptr,  because there are lot of messages, and few of them 
are file transfer messages




Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to