On Sat, 16 Aug 2008 16:13:32 +0200, Dennis Nienhüser <[EMAIL PROTECTED]> wrote:
> Hi Roman, > > very nice :-) > > Quick code comments: > - The result of fileAccess.open() is not checked. For false, the default > html should be used, I think. Yes that would be better. > - maybe rename disabledFileTransferButtons() to > disableFileTransferButtons()? Oh that's a typo :) > - uint fileTransferId, bool fileTransferDisabled, unsigned long fileSize > are not being initialized afaict. It is initialized in Kopete::Message::Private constructor or did you mean something else? > - askIncomingDone() sounds a bit confusing without reading its > description - don't have a better name right now, however ;-) Waiting for suggestions ;) > - nextID is incremented twice. Not sure if that's right/wrong, just > wondered. It was there already and maybe it's good because this way we can distinguish file transfer request and actual file transfer. Roman > Regards, > Dennis > > Roman Jarosz schrieb: >> Hi >> >> I've removed the ugly dialog which is shown when we got file transfer >> request and moved it into the chat window. >> >> It's based on Adium chat style (FileTransferRequest.html) although to >> make >> it more user friendly I had to add four new keywords %fileSize%, >> %saveFileHandlerId%, %saveFileAsHandlerId%, %cancelRequestHandlerId%. >> The three id keywords are used to disable buttons after file transfer >> is accepted or rejected. >> >> If current style doesn't have FileTransferRequest.html Kopete creates >> default one based on current chat style. >> >> Here are screenshots: >> http://kedge.wz.cz/kopete/kopeteft1.png >> http://kedge.wz.cz/kopete/kopeteft2.png >> http://kedge.wz.cz/kopete/kopeteft3.png >> >> Any comments or suggestions? >> >> Regards, >> Roman >> >> PS. Currently there is a bug in khtml which paints disabled buttons as >> active. >> I've already reported this bug. Also there was a bug which has sent >> click events >> even if the button was disabled this bug is already fixed since >> revision 846734. >> Oh and also button accelerators don't work yet also reported to khtml >> guys. >> >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> kopete-devel mailing list >> [email protected] >> https://mail.kde.org/mailman/listinfo/kopete-devel >> > > _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
