----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/131/#review184 -----------------------------------------------------------
See feedback below. Not quite ready yet, but almost. :) /trunk/KDE/kdenetwork/kopete/libkopete/kopeteavatarmanager.cpp <http://reviewboard.kde.org/r/131/#comment94> coding style! brackets should be on separate lines. /trunk/KDE/kdenetwork/kopete/libkopete/kopeteavatarmanager.cpp <http://reviewboard.kde.org/r/131/#comment97> why is the else no longer needed? /trunk/KDE/kdenetwork/kopete/libkopete/kopeteavatarmanager.cpp <http://reviewboard.kde.org/r/131/#comment95> style. /trunk/KDE/kdenetwork/kopete/libkopete/kopeteavatarmanager.cpp <http://reviewboard.kde.org/r/131/#comment96> style - Matt On 2009-02-19 15:39:25, Benson Tsai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/131/ > ----------------------------------------------------------- > > (Updated 2009-02-19 15:39:25) > > > Review request for Kopete. > > > Summary > ------- > > This patch makes the avatar manager save both the original photo and the > resized photo. Although the resizing currently shrinks larger images, it just > pads smaller images until it fits a 96x96 box. This padded image is then > shrunken in areas like the contact list and the chat window. With the patch, > the avatar manager also saves the original image and the protocols are all > set to use the original as profile picture instead of the new one. Also, by > saving the original, there is potential to support animated images (since QT > does not support writing animated images). > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/libkopete/kopeteavatarmanager.h 928660 > /trunk/KDE/kdenetwork/kopete/libkopete/kopeteavatarmanager.cpp 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberbasecontact.cpp 928660 > /trunk/KDE/kdenetwork/kopete/protocols/msn/msncontact.cpp 928660 > /trunk/KDE/kdenetwork/kopete/protocols/oscar/oscarcontact.cpp 928660 > /trunk/KDE/kdenetwork/kopete/protocols/telepathy/telepathycontact.cpp > 928660 > /trunk/KDE/kdenetwork/kopete/protocols/yahoo/yahoocontact.cpp 928660 > > Diff: http://reviewboard.kde.org/r/131/diff > > > Testing > ------- > > I've been using this for a while and all the icons seem to be the proper size. > > > Screenshots > ----------- > > contact list before/after > http://reviewboard.kde.org/r/131/s/22/ > chat before/after > http://reviewboard.kde.org/r/131/s/23/ > > > Thanks, > > Benson > > _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
