> On 2009-02-19 20:44:10, Matt Rogers wrote: > > /trunk/KDE/kdenetwork/kopete/libkopete/kopeteavatarmanager.cpp, line 200 > > <http://reviewboard.kde.org/r/131/diff/1/?file=791#file791line200> > > > > why is the else no longer needed?
That else was never needed. If the "if" branch is taken, then it will return from the function. So anything that happens in the "else" would only occur if and only if the "if" branch is not taken. Thus, the "else" is actually redundant and can be removed. - Benson ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/131/#review184 ----------------------------------------------------------- On 2009-02-19 15:39:25, Benson Tsai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/131/ > ----------------------------------------------------------- > > (Updated 2009-02-19 15:39:25) > > > Review request for Kopete. > > > Summary > ------- > > This patch makes the avatar manager save both the original photo and the > resized photo. Although the resizing currently shrinks larger images, it just > pads smaller images until it fits a 96x96 box. This padded image is then > shrunken in areas like the contact list and the chat window. With the patch, > the avatar manager also saves the original image and the protocols are all > set to use the original as profile picture instead of the new one. Also, by > saving the original, there is potential to support animated images (since QT > does not support writing animated images). > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/libkopete/kopeteavatarmanager.h 928660 > /trunk/KDE/kdenetwork/kopete/libkopete/kopeteavatarmanager.cpp 928660 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberbasecontact.cpp 928660 > /trunk/KDE/kdenetwork/kopete/protocols/msn/msncontact.cpp 928660 > /trunk/KDE/kdenetwork/kopete/protocols/oscar/oscarcontact.cpp 928660 > /trunk/KDE/kdenetwork/kopete/protocols/telepathy/telepathycontact.cpp > 928660 > /trunk/KDE/kdenetwork/kopete/protocols/yahoo/yahoocontact.cpp 928660 > > Diff: http://reviewboard.kde.org/r/131/diff > > > Testing > ------- > > I've been using this for a while and all the icons seem to be the proper size. > > > Screenshots > ----------- > > contact list before/after > http://reviewboard.kde.org/r/131/s/22/ > chat before/after > http://reviewboard.kde.org/r/131/s/23/ > > > Thanks, > > Benson > > _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
