----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/498/ -----------------------------------------------------------
Review request for Kopete. Summary ------- This allows a contact to be displayed (in offline state), even if the ShowAll is not enabled. This is done by adding the property isShowAlways to MetaContact. The effect is that a particular contact is always displayed, regardless of status. Use Case: Many of my friends (this may be something unique to college students in India) prefer to stay invisible rather than come online. If I wish to initiate a chat with them, I need to manually select 'ShowAll', find my friend, start chat, and then unselect 'ShowAll'. However, it is usually just one or two of my friends who i'd want displayed even when offline. I thought such an option would be very valuable. Especially for finding out history, etc... Footnote: Would be great if this can make it by 4.3. Sadly, it will probably miss the soft feature freeze. On the other hand, there is plenty of time till the hard feature freeze, so it is possible to include this in 4.3 by adding this to the features for 4.3 document. Does the maintainer think this is a good idea? Diffs ----- trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistproxymodel.cpp 947928 trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.h 947928 trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp 947928 trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistmodel.cpp 947928 trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitembase.h 947928 trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitemdelegate.cpp 947928 trunk/KDE/kdenetwork/kopete/kopete/kopeteui.rc 947928 trunk/KDE/kdenetwork/kopete/libkopete/contactlist/xmlcontactstorage.cpp 947928 trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.h 947928 trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.cpp 947928 trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact_p.h 947928 Diff: http://reviewboard.kde.org/r/498/diff Testing ------- When I check 'ShowAlways' it is persistent Also, it always shows the contact KNOWN BUGS: If there is not a single online contact in a particular group, then the group is hidden, regardless of whether some of the contacts contained within are marked as 'Show Always' Effects of checking 'Show Always' are only visible next time the contacts state changes (ie, If you select 'Show Always' on a contact that is already offline, it won't show up immediately). This can be fixed by reparsing the contact list when option is set (but I'm unaware of the syntax. Anyone care to help?) Screenshots ----------- The Screenshot http://reviewboard.kde.org/r/498/s/91/ Thanks, gja _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
