> On 2010-01-11 16:32:57, Raphael Kubo da Costa wrote: > > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitemdelegate.cpp, > > line 548 > > <http://reviewboard.kde.org/r/2542/diff/3/?file=16883#file16883line548> > > > > const'ify here too?
Oops, nevermind. Didn't see you called convert(). - Raphael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2542/#review3661 ----------------------------------------------------------- On 2010-01-11 16:20:44, Stefan Geuns wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2542/ > ----------------------------------------------------------- > > (Updated 2010-01-11 16:20:44) > > > Review request for Kopete. > > > Summary > ------- > > The contactlist no longer shows emoticons in recent kopete versions. This > patch re-enables this feature for both the contacts their display name and > status message. > > In the contactlist drawing code I noticed a bug with the drawing of > ContactList::LayoutManager::PlaceHolder, "value == " was missing (twice). > This patch also fixed that. > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistmodel.h 1073101 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistmodel.cpp > 1073101 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitemdelegate.cpp > 1073101 > > Diff: http://reviewboard.kde.org/r/2542/diff > > > Testing > ------- > > > Thanks, > > Stefan > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
