> On Jan. 11, 2010, 9:15 a.m., Roman Jarosz wrote: > > IIRC the Kopete::Emoticons::tokenize can be/is CPU intensive task, maybe it > > would be good to cache it in ContactListModel::metaContactData also if we > > parse emoticons in StatusMessageRole we may as well parse it in > > StatusTitleRole.
I am using this patch for a few days. It works and you right, it is really CPU intensive. The froze for a few seconds in my notebook when clicking on the show offline users button. I think it would be better we could at least cache the QPixmpa generated from the tokens to minimize this problem. Some tokens are still not being translated though, for instance [c=...] [/c] [b] [/b] [u] [u] - Lamarque ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/2542/#review3650 ----------------------------------------------------------- On Jan. 14, 2010, 5:44 p.m., Stefan Geuns wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/2542/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2010, 5:44 p.m.) > > > Review request for Kopete. > > > Summary > ------- > > The contactlist no longer shows emoticons in recent kopete versions. This > patch re-enables this feature for both the contacts their display name and > status message. > > In the contactlist drawing code I noticed a bug with the drawing of > ContactList::LayoutManager::PlaceHolder, "value == " was missing (twice). > This patch also fixed that. > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistmodel.h 1073101 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistmodel.cpp > 1073101 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitemdelegate.cpp > 1073101 > > Diff: http://svn.reviewboard.kde.org/r/2542/diff > > > Testing > ------- > > > Thanks, > > Stefan > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
