Jennifer Pioch writes: > On 12/8/08, April Chin <April.Chin at sun.com> wrote: > > There was a change required to usr/src/Makefile.lint, > > as listed in bugzilla bug #592 > > http://bugs.grommit.com/show_bug.cgi?id=592 (the 2008-12-07 patch). > > This is a change to a file not previously touched. > > > > I've posted the Makefile.lint change > > as an incremental webrev against the webrevs posted Dec 4th: > > > > http://cr.opensolaris.org/~chin/webrev-nonast.dec4-vs-dec6-diffs/ > > Why do we have to review this? The tree won't build without the one-line > patch.
All changes in ON get code review. There are no exceptions, even for one-line changes, and even for cases where the tree doesn't build without the change. That's a standard part of ON development. Other consolidations (of course) are free to set their own rules in any way they like. -- James Carlson, Solaris Networking <james.d.carlson at sun.com> Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
