Jennifer Pioch wrote: > On 12/8/08, April Chin <April.Chin at sun.com> wrote: > > There was a change required to usr/src/Makefile.lint, > > as listed in bugzilla bug #592 > > http://bugs.grommit.com/show_bug.cgi?id=592 (the 2008-12-07 patch). > > This is a change to a file not previously touched. > > > > I've posted the Makefile.lint change > > as an incremental webrev against the webrevs posted Dec 4th: > > > > http://cr.opensolaris.org/~chin/webrev-nonast.dec4-vs-dec6-diffs/ > > Why do we have to review this? The tree won't build without the one-line > patch.
See Mike Kupfer's and James Carlson's reply. I know that many OpenSource projects treat one-line build bustage changes as "self-review" (or better: "You broke it, you clean it up yourself if the fix is obious") but OS/Net has the strict rule (with on exceptions) that all code must be reviewed (imagine someone trying to sneak in lots of code with hundreds of one-line putback). > > You may look at this webrev, in addition to one of the below webrevs > > posted Dec 4th, if you haven't already reviewed the Dec 4th changes: > > > > > Date: Thu, 4 Dec 2008 17:07:31 -0800 (PST) > > > From: April Chin <April.Chin at Sun.COM> > > > > > > ... here are webrevs for the latest changes for ksh93 update1, > > > in response to code review comments so far. > > > > > > For code reviewers of the last changes, posted Nov 28th, here is a > > > diff against the last webrev: > > > http://cr.opensolaris.org/~chin/webrev-nonast.nov28-vs-dec4-diffs/ > > > > > > A current webrev of all the non-AST changes to be reviewed, > > > diff-ed against the OS-Net gate, is at: > > > http://cr.opensolaris.org/~chin/webrev-nonast.dec4 > > I've reviewed http://cr.opensolaris.org/~chin/webrev-nonast.dec4 and > http://cr.opensolaris.org/~chin/webrev-nonast.dec4-vs-dec6-diffs/ and > the changes look good to me. Thanks! :-) ---- Bye, Roland -- __ . . __ (o.\ \/ /.o) roland.mainz at nrubsig.org \__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer /O /==\ O\ TEL +49 641 3992797 (;O/ \/ \O;)
