"I. Szczesniak" wrote:
> On 7/20/09, Roland Mainz <roland.mainz at nrubsig.org> wrote:
> > I need a quick codereview for CR #6862121 ("shbinexec kernel module
> > defunct").
> > The problem is that the current version in OS/Net is based on an older,
> > defunct prototype which was accidently mis-merged by me into the
> > ksh93-integration update1 putback codebase, causing this bug.
> >
> > The patch restores the intended version and fixes a small additional bug
> > which happens if compiled shell scripts start with a '-' character (e.g.
> > the only new line of code is |idata.intp_arg = "--";|).
> >
> > Webrev for review is available at
> >
> > http://cr.opensolaris.org/~gisburn/cr_6862121_shbinexec_kernel_module_defunct_20090720_001/
> >
> > References for reviewers:
> > - javaexec kernel module source:
> >
> > http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/common/exec/java/java.c
> > - interpreter kernel module source:
> >
> > http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/common/exec/intp/intp.c
>
> The patch looks OK. You may want to check whether function shbinexec()
> can be made 'static'.
Fixed.
Additionally I fixed the unneccesary |memset()| (no longer needed since
we set all members of |idata| manually now) per Jennifer's comments.
New webrev is available as
http://cr.opensolaris.org/~gisburn/cr_6862121_shbinexec_kernel_module_defunct_20090720_002/
----
Bye,
Roland
--
__ . . __
(o.\ \/ /.o) roland.mainz at nrubsig.org
\__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer
/O /==\ O\ TEL +49 641 3992797
(;O/ \/ \O;)
