Avi Kivity wrote: > Dong, Eddie wrote: >> Gregory Haskins wrote: >> >>> On Thu, 2007-07-12 at 22:20 +0800, Dong, Eddie wrote: >>> >>> >>> >>>> Apply to current kvm.git? Then we need to define false for >>>> irqchip_in_kernel() which makes the patch quit stranger. >>>> >>> I think what Avi is saying is this can be generalized as a separate >>> feature independent of in-kernel-PIC. Since Avi and I are both >>> advocating a separate capability for in-kernel-HLT, you >>> wouldn't need to >>> have a stubbed irqchip_in_kernel. Rather, you should have a flag >>> that indicates whether userspace enabled the HLT capability or not. >>> >> >> Then Avi need to check in your patch in user level to remove the >> race condition, otherwise the patch does nothing and just some dead >> code. >> >> Avi: >> Can u have a double check to see what you want to do. I am fine >> with either of them. >> > > Like Gregory said: we check in the hlt patch to the kernel, and the > race removal + use the new feature patch for userspace. > > Gregory, can you repost that patch please? Eddie, please test both > with and without the userspace patch. > this is race condition which happens only in certain situation. I am afraid I can reproduce this. Greg said he had done test, right?
------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
