Nitin A Kamble wrote:
> Hi Avi,
> The patch to implement "jmp rel" emulation is attached.
>
> +#define jmp_rel(rel) \
> +do { \
> + _eip += (int)(rel); \
> + _eip = ((op_bytes == 2) ? (uint16_t)_eip : (uint32_t)_eip); \
> +} while (0)
> +
Please use an inline function instead of a macro. That will help when
we later make large scale changes (for example, splitting the emulator
into a decoder and executor).
(and, when defining the macro, indent the contents)
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel
