Nitin A Kamble wrote: > Hi Avi, > Attached is a patch to implement instruction: > push reg (opcode 0x50 - 0x57) > Please apply or comment. > > > + case 0x50 ... 0x57: /* push reg */ > + if (op_bytes == 2) > + src.val = (u16) _regs[b & 0x7]; > + else > + src.val = (u32) _regs[b & 0x7]; > + dst.type = OP_MEM; > + dst.bytes = op_bytes; > + dst.val = src.val; > + register_address_increment(_regs[VCPU_REGS_RSP], -op_bytes); > + dst.ptr = (void *) register_address( > + ctxt->ss_base, _regs[VCPU_REGS_RSP]); > + d |= Mov; /* force writeback */ > + break; > } >
I don't thing 'd |= Mov' is necessary any more to force writeback. Please check. Also, please keep opcodes in sorted order. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
