Jerone Young wrote:
> # HG changeset patch
> # User Jerone Young <[EMAIL PROTECTED]>
> # Date 1193618330 18000
> # Node ID 3bf072e498768885ab96b7ccb668b61c96db0e83
> # Parent a6f7c585fe76f9563fd061cfe3e772532ab27952
> Move x86 kvmcallback structure to kvmctl-x86.h header.
>
> This patch moves the kvmcallback structure that is currently in
> kvmctl.h into an arch specific header.
>
> Signed-off-by: Jerone Young <[EMAIL PROTECTED]>
>
> new file mode 100644
>
> diff --git a/user/kvmctl-x86.h b/user/kvmctl-x86.h
> new file mode 100644
> --- /dev/null
> +++ b/user/kvmctl-x86.h
> @@ -0,0 +1,54 @@
> +#ifndef KVMCTL_X86_H
> +#define KVMCTL_X86_H
> +
> +/*!
> + * \brief KVM callbacks structure
> + *
> + * This structure holds pointers to various functions that KVM will
> call + * when it encounters something that cannot be virtualized,
> such as + * accessing hardware devices via MMIO or regular IO.
> + */
> +struct kvm_callbacks {
> + /// For 8bit IO reads from the guest (Usually when executing
'inb')
> + int (*inb)(void *opaque, uint16_t addr, uint8_t *data);
> + /// For 16bit IO reads from the guest (Usually when executing
'inw')
> + int (*inw)(void *opaque, uint16_t addr, uint16_t *data);
I don't know the privious story about this thread, but now I can't
understand the move. Why do we move all the structure to arch-specific ?
For IA64 side, almostly we can reuse them directly, and just see some
special fields as arch-specific. So, I think, we should keep common
fields in kvmctl.h.
>
> /*!
> * \brief Create new KVM context
>
>
------------------------------------------------------------------------
-
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems? Stop.
> Now Search log events and configuration files using AJAX and a
> browser. Download your FREE copy of Splunk now >>
> http://get.splunk.com/ _______________________________________________
> kvm-devel mailing list
> kvm-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/kvm-devel
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel
