Well no response might mean that there is nothing to be said against this simplification ;-) Because of that I completed the patch (main.c as well) and corrected some whitespace issues I had before.
Christian Ehrhardt wrote: > Background: > In our ppc code for the demo we only needed a call to > cpu_physical_memory_rw to handle all kind of mmio we needed. Looking at > all the callback pointers for read/write mmio in kvm_callbacks I > wondered if this can be simplified with cpu_physical_memory_rw for x86 > too. So I tested it today and it works fine on with kvm-svm on my opteron. > The only code that did not just redirect to another function was a > workaround for a Redhat 7.1 issue, so I merged it in the central call > making it easier to find and maintain (was split before) anyway. > If everyone agrees with it I will create a new patch also affecting the > other implementations of this interface e.g. user/main.c and a rebased > version of this one. > But maybe there was a reason to do it that split way with all the > callback pointers that was not obvious to me, so please comment. > [...] -- Grüsse / regards, Christian Ehrhardt IBM Linux Technology Center, Open Virtualization +49 7031/16-3385 [EMAIL PROTECTED] [EMAIL PROTECTED] IBM Deutschland Entwicklung GmbH Vorsitzender des Aufsichtsrats: Johann Weihen Geschäftsführung: Herbert Kircher Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
