Yang, Sheng wrote: > Thanks for comments! > > On Wednesday 05 March 2008 17:15:29 Ingo Molnar wrote: > >> * Yang, Sheng <[EMAIL PROTECTED]> wrote: >> >>> +#if 1 >>> +#define pit_debug(fmt, arg...) printk(KERN_WARNING fmt, ##arg) >>> +#else >>> +#define pit_debug(fmt, arg...) >>> +#endif >>> >> this should use pr_debug() instead i guess. >> > > Um... I followed example on ./virt/kvm/ioapic.c here. Though I think it's > good > to substitute all self defined debug printk with pr_debug, why KVM have > little pr_xxx(the only ones are in x86.c)? Maybe for KVM is acting more like > a separate driver, and using printk is easier for separate debug? I really > don't know... > >
It's mostly due to lack of knowledge about pr_debug(); it wasn't intentional. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
