* Yang, Sheng <[EMAIL PROTECTED]> wrote:
> > * Yang, Sheng <[EMAIL PROTECTED]> wrote:
> > > +#if 1
> > > +#define pit_debug(fmt, arg...) printk(KERN_WARNING fmt, ##arg)
> > > +#else
> > > +#define pit_debug(fmt, arg...)
> > > +#endif
> >
> > this should use pr_debug() instead i guess.
>
> Um... I followed example on ./virt/kvm/ioapic.c here. Though I think
> it's good to substitute all self defined debug printk with pr_debug,
> why KVM have little pr_xxx(the only ones are in x86.c)? Maybe for KVM
> is acting more like a separate driver, and using printk is easier for
> separate debug? I really don't know...
it's just a small detail - it's really not a big issue and my suggestion
should be functionally equivalent. What i meant is that with pr_debug()
you can remove the pit_debug() define altogether (and change all
pit_debug's to pr_debug). In that case all you need to do is to get the
printks is to stick this to the head of the source code file (to before
the include files):
#define DEBUG
and the pr_debug() calls turn from a NOP into a printk(KERN_DEBUG,...).
Ingo
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel
