On Sat, 2008-07-05 at 13:55 +0300, Avi Kivity wrote:
> Ben-Ami Yassour wrote:
> > From: Kay, Allen M <[EMAIL PROTECTED]>
> >
> > This patch extends the VT-d driver to support KVM
> >
> > [Ben: fixed memory pinning]
> >
> > Signed-off-by: Kay, Allen M <[EMAIL PROTECTED]>
> > Signed-off-by: Weidong Han <[EMAIL PROTECTED]>
> > Signed-off-by: Ben-Ami Yassour <[EMAIL PROTECTED]>
> > ---
> > drivers/pci/dmar.c | 4 +-
> > drivers/pci/intel-iommu.c | 117 ++++++++++++++-
> > drivers/pci/intel-iommu.h | 344
> > -------------------------------------------
> > drivers/pci/iova.c | 2 +-
> > drivers/pci/iova.h | 52 -------
> > include/linux/intel-iommu.h | 344
> > +++++++++++++++++++++++++++++++++++++++++++
> > include/linux/iova.h | 52 +++++++
> > 7 files changed, 512 insertions(+), 403 deletions(-)
> > delete mode 100644 drivers/pci/intel-iommu.h
> > delete mode 100644 drivers/pci/iova.h
> > create mode 100644 include/linux/intel-iommu.h
> > create mode 100644 include/linux/iova.h
> >
>
> Please use the git diff '-M' flag (or set the 'diff.renames' config
> variable) so rename patches are reviewable.
>
> >
> > +void kvm_intel_iommu_domain_exit(struct dmar_domain *domain)
> > +{
> > + u64 end;
> > +
> > + /* Domain 0 is reserved, so dont process it */
> > + if (!domain)
> > + return;
> > +
> > + end = DOMAIN_MAX_ADDR(domain->gaw);
> > + end = end & (~PAGE_MASK_4K);
> > +
> > + /* clear ptes */
> > + dma_pte_clear_range(domain, 0, end);
> > +
> > + /* free page tables */
> > + dma_pte_free_pagetable(domain, 0, end);
> > +
> > + iommu_free_domain(domain);
> > + free_domain_mem(domain);
> > +}
> > +EXPORT_SYMBOL_GPL(kvm_intel_iommu_domain_exit);
> >
>
> I don't understand why the names are prefixed with 'kvm_'. These are
> not kvm functions.
The two comments were fixed in the new version of the patches that I
just sent.
>
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
