Amit Shah wrote: > * On Wednesday 15 Oct 2008 12:41:17 Sheng Yang wrote: >> On Wednesday 15 October 2008 15:03:39 Amit Shah wrote: >>> * On Wednesday 15 Oct 2008 08:06:30 Sheng Yang wrote: >>>>>> @@ -4115,6 +4116,9 @@ struct kvm *kvm_arch_create_vm(void) >>>>>> INIT_LIST_HEAD(&kvm->arch.active_mmu_pages); >>>>>> INIT_LIST_HEAD(&kvm->arch.assigned_dev_head); >>>>>> >>>>>> + /* Reserve bit 0 of irq_sources_bitmap for userspace irq >>>>>> source */ + kvm->arch.irq_sources_bitmap = 1; >>>>>> + >>>> >>>> Amit, could you help to use 1 << KVM_USERSPACE_IRQ_SOURCE_ID here, >>>> I come to think it's more proper. :) >>> >>> This is fine; if you think there has to be a change, the change >>> could be done in the .h: >>> >>> - #define KVM_USERSPACE_IRQ_SOURCE_ID 0 >>> + #define KVM_USERSPACE_IRQ_SOURCE_ID 1 << 0 >> >> Well, I think it's a semantics thing... irq_sources_bitmap is a >> bitmap, it can't equal to a source_id... So maybe >> >> set_bit(KVM_USERSPACE_IRQ_SOURCE_ID, &kvm->arch.irq_sources_bitmap); >> >> is the best way here. :) > > OK; I see your point. Can you work with Xiantao and update the patch?
Okay, I will update the patch to make it work for ia64. Thanks! Xiantao -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
