* On Thursday 16 Oct 2008 13:51:38 Avi Kivity wrote:
> Zhang, Xiantao wrote:
> > Forget to modify the from item generated automatically by git.  Modified
> > to Sheng Yang <[EMAIL PROTECTED]>  :)
> > Xiantao
> >
> > From c0d1ad6327c01ba0584922022bef48c971bbf18a Mon Sep 17 00:00:00 2001
> > From: Sheng Yang <[EMAIL PROTECTED]>
> > Date: Wed, 15 Oct 2008 20:15:06 +0800
> > Subject: [PATCH] KVM: Fix guest shared interrupt with in-kernel irqchip
> >
> > Every call of kvm_set_irq() should offer an irq_source_id, which is
> > allocated by kvm_request_irq_source_id(). Based on irq_source_id, we
> > identify the irq source and implement logical OR for shared level
> > interrupts.
> >
> > The allocated irq_source_id can be freed by kvm_free_irq_source_id().
> >
> > Currently, we support at most sizeof(unsigned long) different irq
> > sources.
> >
> >
> >
> > +#define KVM_USERSPACE_IRQ_SOURCE_ID        1 << 0
> > +
>
> This is dangerous, if used in an expression together with a higher
> precedence operator.  I fixed it and applied.  Thanks to all involved.

Thanks; however, Sheng suggested we should use set_bit to set the 
corresponding bit since we're operating on bitfields in a bitmap.

Amit
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to