On Wed, Oct 29, 2008 at 11:15:10AM +0000, Mark McLoughlin wrote: > On Wed, 2008-10-29 at 12:31 +0200, Muli Ben-Yehuda wrote: > > On Tue, Oct 28, 2008 at 04:55:22PM +0000, Mark McLoughlin wrote: > > > > nr_assigned_devices isn't actually used anywhere. > > > > Nuked. > > Still there. > > > > > +#define MAX_IO_REGIONS (6) > > > > > > Perhaps a comment to say this is the number of BARs in the config space > > > header? > > > > Sure, comments are cheap. > > You didn't add one though :-) > > > > > + > > > > + if (kvm_enabled() && device_assignment_enabled) { > > > > > > The device_assignment_enabled flag looks like it shouldn't be needed. > > > > > > If assigned_devices_index remains zero, nothing should happen > > > anyway. > > > > Nuked. > > Still there.
Sorry, I messed up the rebase! v10 coming up in a few minutes. Cheers, Muli -- The First Workshop on I/O Virtualization (WIOV '08) Dec 2008, San Diego, CA, http://www.usenix.org/wiov08/ <-> SYSTOR 2009---The Israeli Experimental Systems Conference http://www.haifa.il.ibm.com/conferences/systor2009/ -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html