Anthony Liguori wrote:
+static int nested = 0;
+module_param(nested, int, S_IRUGO);

Instead of doing this as a module parameter, we could either avoid advertising SVM support in cpuid from userspace or we could disable SVM in the BIOS.

I really like the later approach because it gives a better error message within the guest. We could also keep the module parameter but it would be nice to support disabling SVM in userspace too.

We do need to expose svme in KVM_GET_SUPPORTED_CPUID, so userspace can enable it if it wants. But I'd like to keep the module parameter (defaulting to off) until this has been tested better.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to