On 30.10.2008, at 20:24, Avi Kivity wrote:

Anthony Liguori wrote:
+static int nested = 0;
+module_param(nested, int, S_IRUGO);


Instead of doing this as a module parameter, we could either avoid advertising SVM support in cpuid from userspace or we could disable SVM in the BIOS.

I really like the later approach because it gives a better error message within the guest. We could also keep the module parameter but it would be nice to support disabling SVM in userspace too.

We do need to expose svme in KVM_GET_SUPPORTED_CPUID, so userspace can enable it if it wants. But I'd like to keep the module parameter (defaulting to off) until this has been tested better.

Sure, but we can do both. Joerg was bugging me before a lot because he wanted to have SVM switched on on a per-guest basis. This would basically enable us to do that - still guarded by the kernel module parameter.

Alex

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to