----- Original Message ----- > Il 16/09/2014 14:43, Andrew Jones ha scritto: > > I don't think we need to worry about this case. AFAIU, enabling the > > caches for a particular cpu shouldn't require any synchronization. > > So we should be able to do > > > > enable caches > > spin_lock > > start other processors > > spin_unlock > > Ok, I'll test and apply your patch then. > > Once you change the code to enable caches, please consider hanging on > spin_lock with caches disabled.
Unfortunately I can't do that without changing spin_lock into a wrapper function. Early setup code calls functions that use spin_locks, e.g. puts(), and we won't want to move the cache enablement into early setup code, as that should be left for unit tests to turn on off as they wish. Thus we either need to be able to change the spin_lock implementation dynamically, or just leave the test/return as is. drew > > Paolo > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
