On Sun, Oct 17, 2010, Avi Kivity wrote about "Re: [PATCH 03/27] nVMX: Implement VMXON and VMXOFF": > >+static int handle_vmon(struct kvm_vcpu *vcpu) >.. > >+ if (!nested || > > Is the !nested case needed? Presumably cr4.vmxe will be clear is !nested.
Right - I just added this as a redundant security measure - even if you somehow manage to set cr4.VMXE, you still won't be able to turn on vmx when the 'nested' module option is off. If you don't like it, I'll remove this extra test. -- Nadav Har'El | Sunday, Oct 17 2010, 9 Heshvan 5771 [email protected] |----------------------------------------- Phone +972-523-790466, ICQ 13349191 |:(){ :|:&};: # DANGER: DO NOT run this, http://nadav.harel.org.il |unless you REALLY know what you're doing! -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
