On 10/17/2010 03:18 PM, Nadav Har'El wrote:
On Sun, Oct 17, 2010, Avi Kivity wrote about "Re: [PATCH 05/27] nVMX: Introduce vmcs12: a VMCS structure for L1": > >+ if(to_vmx(vcpu)->nested.current_vmptr != -1ull){ > > Missing whitespace after if and before {.Sorry about that - I forgot to run checkpatch.pl on this iteration. I now fixed this, and a bunch of other small style issues. > > } > >@@ -4170,6 +4229,10 @@ static void vmx_free_vcpu(struct kvm_vcp > > struct vcpu_vmx *vmx = to_vmx(vcpu); > > > > free_vpid(vmx); > >+ if (vmx->nested.vmxon&& to_vmx(vcpu)->nested.current_vmptr != > >-1ull){ > >+ kunmap(to_vmx(vcpu)->nested.current_vmcs12_page); > >+ nested_release_page(to_vmx(vcpu)->nested.current_vmcs12_page); > >+ } > > Duplication - helper? Ok, I just moved the kunmap() into nested_release_page() - it was always called before nested_release_page. I hope that's what you meant by "duplication".
I meant the 4-line sequence duplicates the preceding hunk. So you could have a function that does it and call it twice.
-- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
