On 2011-05-29 18:16, Avi Kivity wrote: > On 05/27/2011 03:19 PM, Jan Kiszka wrote: >> Most tests in kvm_update_interrupt_request are unneeded today: >> - env argument is always non-NULL (caller references it as well) >> - current_env must have been created when we get here >> - env->thread can't be zero (initialized early during cpu creation) >> >> So simply avoid self signaling and multiple kicks, drop the rest. >> > > Why must there be a current_env? > > Although the logic you remove seems to be meaningless. It folds back to > the new code whether current_env is set or not.
Are you commenting on the removed code or on the new one now? I assume to old complex current_env check was once added to work around initialization ordering problems. I do not see them in the way qemu starts up, but I also do not have a clear picture of the original issues anymore. Jan
signature.asc
Description: OpenPGP digital signature
